RFC: palmtx patch authors on handhelds.org

Hi all,

it's very nice to see that the palmtx code is moving (somehow) upstream:

http://handhelds.org/cgi-bin/cvsweb.cgi/linux/kernel26/arch/arm/mach-pxa...


/*
* Hardware definitions for PalmTX
*
* Authors: Marek Vasut
*
...

Although Marek and others can be surely confirmed as the actual maintainers of the code, it would be nice to see a credit for the peoples that started and contributed to the port in the last years.

Dunno why there's no more trace of the 'linux4palm' project in the hackndev subversion repository on sourceforge, but there are still 'traces' of the initial contributors on this git repository:

http://git.hackndev.com/?p=linux-hnd;a=blob_plain;f=arch/arm/mach-pxa/pa...


* Hardware definitions for Palm TX
*
* Based on: palmld.c from Alex Osborne
*
* Authors: Alex Osborne
* Cristiano P. (adapted for Palm TX)
* Jan Herman <2hp@seznam.cz>

I would appreciate if you could add this information (and any other person that contributed).

Thank you for your attention!

greetz,
cris

All credits were changed to

All credits were changed to Marex? I don't think it's ok. I don't care about my personal credits, but he should mention others.

and what should I do if I

and what should I do if I rewrote that file from scratch ? Sure, I can send a patch about it if you want to, give me what you want there

and I'd be very glad if you

and I'd be very glad if you could check palmld, it's copypaste from there ... and palmld is copypaste from palmt5.

ok, I will send patch adding this, but I need your real name and email please:

Contributions by:
Cristiano P.... - started the port
* Jan Herman email hidden
* Alex Osborne email hidden

I will add them to mainline as well

Hello Marex, nice to hear

Hello Marex,

nice to hear (or read) from you.

Both palmtx and palmt5 are derived from the initial palmld code from Alex (as other devices as well) as you might well remember.

Anyway at

http://handhelds.org/cgi-bin/cvsweb.cgi/linux/kernel26/arch/arm/mach-pxa...


/*
* linux/arch/arm/mach-pxa/palmld/palmld.c
*
* Support for the Palm LifeDrive.
*
* Author: Alex Osborne
* Marek Vasut
*/

the credits have been set correctly.

It would be nice to see the same for the other files as well.

greetz,
cris

yea, sorry for that, it

yea, sorry for that, it happened by copypasting from T5, will send a patch right away

diff -Naru

diff -Naru linux.orig/kernel26/arch/arm/mach-pxa/palmtt5/palmtt5.c linux/kernel26/arch/arm/mach-pxa/palmtt5/palmtt5.c
--- linux.orig/kernel26/arch/arm/mach-pxa/palmtt5/palmtt5.c 2008-05-02 21:30:55.000000000 +0200
+++ linux/kernel26/arch/arm/mach-pxa/palmtt5/palmtt5.c 2008-07-08 14:27:19.389278621 +0200
@@ -1,7 +1,12 @@
/*
* Hardware definitions for PalmTT5
*
- * Authors: Marek Vasut
+ * Authors: Marek Vasut
+ * Cristiano P.
+ * Jan Herman <2hp@seznam.cz>
+ * Michal Hrusecky
+ *
+ * based on palmld.c by Alex Osborne
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
diff -Naru linux.orig/kernel26/arch/arm/mach-pxa/palmtx/palmtx.c linux/kernel26/arch/arm/mach-pxa/palmtx/palmtx.c
--- linux.orig/kernel26/arch/arm/mach-pxa/palmtx/palmtx.c 2008-07-01 18:11:47.026180207 +0200
+++ linux/kernel26/arch/arm/mach-pxa/palmtx/palmtx.c 2008-07-08 14:35:39.905858277 +0200
@@ -2,6 +2,11 @@
* Hardware definitions for PalmTX
*
* Authors: Marek Vasut
+ * Cristiano P.
+ * Jan Herman <2hp@seznam.cz>
+ * MIchal Hrusecky
+ *
+ * based on palmld.c by Alex Osborne
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
diff -Naru linux.orig/kernel26/include/asm-arm/arch-pxa/palmtt5-gpio.h linux/kernel26/include/asm-arm/arch-pxa/palmtt5-gpio.h
--- linux.orig/kernel26/include/asm-arm/arch-pxa/palmtt5-gpio.h 2008-05-02 21:30:55.000000000 +0200
+++ linux/kernel26/include/asm-arm/arch-pxa/palmtt5-gpio.h 2008-07-08 14:28:59.686922781 +0200
@@ -4,6 +4,8 @@
* Based on palmld-gpio.h by Alex Osborne
*
* Authors: Marek Vasut
+ * Cristiano P.
+ * Jan Herman <2hp@seznam.cz>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as

ok ?

diff --git

diff --git a/arch/arm/mach-pxa/palmtx.c b/arch/arm/mach-pxa/palmtx.c
index 1bbe501..7aaae43 100644
--- a/arch/arm/mach-pxa/palmtx.c
+++ b/arch/arm/mach-pxa/palmtx.c
@@ -3,6 +3,12 @@
*
* Authors: Marek Vasut
*
+ * Based on code by:
+ * Alex Osborne
+ * Cristiano P.
+ * Jan Herman <2hp@seznam.cz>
+ * Michal Hrusecky
+ *
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.

and this for mainline ... ok ?

Hi Marex, I'd be happy if

Hi Marex,

I'd be happy if you would modify the only palmtx.c as follows:


* Hardware definitions for Palm TX
*
* Based on: palmld.c from Alex Osborne
*
* Authors: Alex Osborne
* Cristiano P.
* Jan Herman <2hp@seznam.cz>
* Marex Vasut

I didn't work on the T5 project.

Thank you for your help!

greetz,
cristiano

diff -Naru

diff -Naru linux.orig/kernel26/arch/arm/mach-pxa/palmtt5/palmtt5.c linux/kernel26/arch/arm/mach-pxa/palmtt5/palmtt5.c
--- linux.orig/kernel26/arch/arm/mach-pxa/palmtt5/palmtt5.c 2008-05-02 21:30:55.000000000 +0200
+++ linux/kernel26/arch/arm/mach-pxa/palmtt5/palmtt5.c 2008-07-08 14:42:53.653276214 +0200
@@ -1,7 +1,12 @@
/*
* Hardware definitions for PalmTT5
*
- * Authors: Marek Vasut
+ * Authors: Marek Vasut
+ * Cristiano P.
+ * Jan Herman <2hp@seznam.cz>
+ * Michal Hrusecky
+ *
+ * based on palmld.c by Alex Osborne
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
diff -Naru linux.orig/kernel26/arch/arm/mach-pxa/palmtx/palmtx.c linux/kernel26/arch/arm/mach-pxa/palmtx/palmtx.c
--- linux.orig/kernel26/arch/arm/mach-pxa/palmtx/palmtx.c 2008-07-01 18:11:47.026180207 +0200
+++ linux/kernel26/arch/arm/mach-pxa/palmtx/palmtx.c 2008-07-08 14:54:19.517278295 +0200
@@ -1,7 +1,12 @@
/*
* Hardware definitions for PalmTX
*
- * Authors: Marek Vasut
+ * based on palmld.c by Alex Osborne
+ *
+ * Authors: * Cristiano P.
+ * Jan Herman <2hp@seznam.cz>
+ * MIchal Hrusecky
+ * Marek Vasut
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
diff -Naru linux.orig/kernel26/include/asm-arm/arch-pxa/palmtt5-gpio.h linux/kernel26/include/asm-arm/arch-pxa/palmtt5-gpio.h
--- linux.orig/kernel26/include/asm-arm/arch-pxa/palmtt5-gpio.h 2008-05-02 21:30:55.000000000 +0200
+++ linux/kernel26/include/asm-arm/arch-pxa/palmtt5-gpio.h 2008-07-08 14:42:13.432011614 +0200
@@ -4,6 +4,8 @@
* Based on palmld-gpio.h by Alex Osborne
*
* Authors: Marek Vasut
+ * Cristiano P.
+ * Jan Herman <2hp@seznam.cz>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as

-------------------------

diff --git a/arch/arm/mach-pxa/palmtx.c b/arch/arm/mach-pxa/palmtx.c
index 1bbe501..63eef25 100644
--- a/arch/arm/mach-pxa/palmtx.c
+++ b/arch/arm/mach-pxa/palmtx.c
@@ -1,7 +1,11 @@
/*
* Hardware definitions for PalmTX
*
- * Authors: Marek Vasut
+ * Authors: Alex Osborne
+ * Cristiano P.
+ * Jan Herman <2hp@seznam.cz>
+ * Michal Hrusecky
+ * Marek Vasut
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as

better ?
the patch under the line is for mainline palmtx ... the third rewrite (mainline is way too different)

if this the diff you will

if this the diff you will send

diff --git a/arch/arm/mach-pxa/palmtx.c b/arch/arm/mach-pxa/palmtx.c
index 1bbe501..63eef25 100644
--- a/arch/arm/mach-pxa/palmtx.c
+++ b/arch/arm/mach-pxa/palmtx.c
@@ -1,7 +1,11 @@
/*
* Hardware definitions for PalmTX
*
- * Authors: Marek Vasut
+ * Authors: Alex Osborne
+ * Cristiano P.
+ * Jan Herman <2hp@seznam.cz>
+ * Michal Hrusecky
+ * Marek Vasut
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as

yes. ;)

thank you!

greetz,
cris

what's the difference ?

what's the difference ?

just what below

just what below the

-------------------------

the patch above had lines for the t5 as well -> I didn't do any activity there ...

thanks again!

PS: I hate this 'Math question Captcha' :P

that one below the line is

that one below the line is for mainline palmtx as I told you ... not the -hh one

you have it there ... it

you have it there ... it will be commited asap

I've read that line only

I've read that line only after the post ... sorry.

I think you can safely remove my name from the T5 files: I did not put any effort in that port.

well are you satisfied now

well are you satisfied now and can we close this issue ?

thanx for your

thanx for your fair-play!

greetz,
cris

still you can check the

still you can check the mainline palmtx as well ... if there is anything you wrote or anything based on palmld etc.

btw are you willing to contribute to the project anymore ?

as for -hh, yea, that was a mistake and will be corrected soon, as for mainline, Im still curious. I reused only the header files and your credit is there.

> btw are you willing to

> btw are you willing to contribute to the project anymore ?

I always wanted ... but I had not that much time the last years.
And still, I never 'felt home' here @H&D: I hope you understand what I mean.

> as for -hh ... as for mainline ...

look at the title of this post: RFC: palmtx patch authors on handhelds.org
I didn't even know things were going mainline ...

It was just sad to see these efforts get lost ...

>> btw are you willing to

>> btw are you willing to contribute to the project anymore ?
>
>I always wanted ... but I had not that much time the last years.
>And still, I never 'felt home' here @H&D: I hope you understand what I mean.

No I dont ...

>
>> as for -hh ... as for mainline ...
>
>look at the title of this post: RFC: palmtx patch authors on handhelds.org
>I didn't even know things were going mainline ...
>
>It was just sad to see these efforts get lost ...

this is going in mainline http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=5153/1 ... rewrite #3
but if you want your name even there (if you still see your or alex's code), it wont be too much problem I think

> but if you want your name

> but if you want your name even there (if you still see your or alex's code)
> it wont be too much problem I think

my concerns were about the hh patch. thx.

ok, so I will leave mainline

ok, so I will leave mainline this way (like the patch is in the link) and put the hh patch in hh ... hh is dead anyway, but ok, you're right. Your name is in the mainline headers since you determined the GPIOs and stuff, thanks.

patches are pending to be merged, this is CLOSED. Will be more careful next time.

I can find similar parts in

I can find similar parts in mainline patch, but I think the main point is, that this way it leaves misleading impression that TX port was just your work. And once hackndev and handhelds dies, there will be only this misleading trace of development of TX port.

probably because it's the

probably because it's the same device ? if it makes you happy, there is patch pending adding "based on work of:"
but if you were so concerned about palmtx, why didnt you checked the patches? they were in mailing list for more than a week.

Thank you, I'll surely test

Thank you, I'll surely test it when I'll get my palm back.

@miska: ------- the

@miska:
-------
the 'linux4palm' project into the old subversion repository has already 'magically' disappeared with all its history ...

it's a matter of behavior (and respect, I dare).
Even after I left this community I couldn't forget all involved people, e.g.:

http://www.nabble.com/-PATCH--support-for-Palm-LD-TX-Z72-handhelds-td879...
http://bugs.openembedded.net/show_bug.cgi?id=1687#c0
...

And I feel good!

Anyway, thank you all for your effort! you're doing a great job!

cristiano: linux4palm

cristiano:
linux4palm disappeared because of some problem with SVN last year and hackndev repository was moved to git...

you mean: purposely damaged

you mean: purposely damaged to enforce switching to git or whatever other reason?

Our svn tree has been

Our svn tree has been corrupted by sf.net server. We've lost some code and decided to move to self-hosted DVCS repository. That has not been done on purpose. There were talks to move to DVCS (started by me), but the overall community decided to stick with svn. That was just a matter of fact. All of the active developers were aware of that change.

from

from http://alexandria.wiki.sourceforge.net/Data+Backup+and+Restore:

SourceForge.net maintains system backups of all data stored on SourceForge.net servers. These backups are made on at least a weekly basis, and in most cases on a daily basis. The primary backup media is tape. Data that users or SourceForge.net administrators 'delete' from the SourceForge.net site is merely hidden, but retained for perpituity.

The backups are maintained for use in case of a catastrophe, such as a major host loss, earthquake or fire. SourceForge.net administrative staff define when such a catastrophe has occurred.

...

If the loss has been caused by the sf stuff (or from an admin or the project) why nobody requested a restore?
just for historical reason ...

nevertheless, the whole kernel tree is not anymore available ... pity ... no trace of the 'linux4palm' directory in any revision ...

IIRC (that was pretty long

IIRC (that was pretty long time ago), the backups were broken or something. You can ask Alex for details, he was the one who contacted sf staff (and ported tree to git). Kernel code and tools have been split into corresponding repositories at git.hackndev.com.

sf.net SVN repository is not removed, and is kept for "historical" reasons. Last available revision is r 1163 (of 1350). If you really want, I can provide you with access to see repository in "restored state".

Marek has added (c) for you to the code. Any other points you don't personally like?

One more comment. There was

One more comment. There was an urge need of cleaning and upstreaming the code. Kaafree even had set up a bounty for ones who will upstream projects code. Marek has done a great job of cleaning everything up and posting it to LAKML. Why didn't you do the same? There was plenty of time.

So I see absolutely no reason to be angry with Marek.

> ... the backups were

> ... the backups were broken or something
I could ask you to make available the evidences of your affirmations, but I'm so tired and bored ...

> Last available revision is r 1163 (of 1350)
svn co -r 1163 https://hackndev.svn.sourceforge.net/svnroot/hackndev/linux4palm
svn: REPORT request failed on '/svnroot/hackndev/!svn/bc/1350/linux4palm'
svn: '/svnroot/hackndev/!svn/bc/1350/linux4palm' path not found

> sf.net SVN repository is not removed, and is kept for "historical" reasons.
the repository is corrupted and has not been restored: all the historical information about the work of many people that contributed to the 'linux4palm' project has been lost

> Why didn't you do the same?
this is the nature of opensource projects: one starts a project, some other continue it. Many other may contribute in the future.

Each one respect each other work and each one acts fairly.

I respect and I admire what Marex did, but you all guys were absolutely not fair.

See here:

See here: http://hackndev.com/node/46

We weren't the only project affected. SF.net's response was just something like "Projects are responsible for their own backups. See the documentation for how to use our SVN import tool to fix it yourself." I guess they didn't deem it a "catastrophe, such as a major host loss, earthquake or fire". I should still have the massive SVN dump file somewhere if you really want it. I attempted to restore as much of the respository as possible, but the linux4palm directory was too big and the SVN import tool kept rejecting it.

> I respect and I admire what Marex did, but you all guys were absolutely not fair.

Sorry, it would have been better to go with git on our own hosting right from the very start which would have avoided all the trouble SF SVN has been (especially for rebasing), and everyone's working directory would be a backup. I don't think either Farcaller or I had really used it back then though, so it didn't occur to us at the time.

I don't criticize your

I don't criticize your decision to migrate to another SCM.

I'm sad and disappointed of the way this community behaves ... a general 'deception' feeling ...

BTW, I'll submit my complaints elsewhere if needed.

> I should still have the

> I should still have the massive SVN dump file somewhere if you really want it.

Alex, could you be so kind to make it available somewhere? Thank you!

This should be

This should be it:

http://releases.hackndev.com/hackndev-svndump-fixed-corruption.bz2
MD5: e95d863fb50cab0e8e224ab3e71ea641

You can turn it into a repository by doing something like:

svnadmin create hackndev-svn
bzcat hackndev-svndump-fixed-corruption.bz2 | svnadmin load hackndev-svn

Then you can checkout or whatever as normal:

svn co file://$(pwd)/hackndev-svn hackndev-checkout

> This should be it:

> This should be it: ...

thank you!

> You can turn it into a repository by doing something like: ...

don't worry, I've worked 'a bit' with subversion repositories in the last years ...

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.